github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-04-10 03:01:51 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix: [wc|bw]-created events do not emit an event object (#19465)

Browse Source 
* fix: emit real Event instead of empty object in [wc|bw]

* chore: add ability to emit empty events
This commit is contained in:
Shelley Vohr
2019-07-29 13:54:37 -07:00
committed by GitHub
parent 33d1e87163
commit aaca9011ae
5 changed files with 17 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
lib/browser/api/browser-window.js
View File

@@ -82,7 +82,8 @@ BrowserWindow.prototype._init = function () {
}
// Notify the creation of the window.
app.emit('browser-window-created', {}, this)
const event = process.electronBinding('event').createEmpty()
app.emit('browser-window-created', event, this)
Object.defineProperty(this, 'devToolsWebContents', {
enumerable: true,

3
lib/browser/api/web-contents.js
View File

@@ -413,7 +413,8 @@ WebContents.prototype._init = function () {
})
}
app.emit('web-contents-created', {}, this)
const event = process.electronBinding('event').createEmpty()
app.emit('web-contents-created', event, this)
}
// Deprecations