From ae0064d787a8c18306abc626b11a5cf8484f012f Mon Sep 17 00:00:00 2001 From: Erick Zhao Date: Tue, 28 Jan 2020 14:16:42 -0800 Subject: [PATCH] docs: remove references to inaccessible team pages (#21923) --- docs/development/pull-requests.md | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/docs/development/pull-requests.md b/docs/development/pull-requests.md index 19960889ff..53eec08275 100644 --- a/docs/development/pull-requests.md +++ b/docs/development/pull-requests.md @@ -221,11 +221,12 @@ seem unfamiliar, refer to this #### Approval and Request Changes Workflow -All pull requests require approval from a [Code Owner](https://github.com/orgs/electron/teams/code-owners) of the area you -modified in order to land. Whenever a maintainer reviews a pull request they -may request changes. These may be small, such as fixing a typo, or may involve -substantive changes. Such requests are intended to be helpful, but at times -may come across as abrupt or unhelpful, especially if they do not include +All pull requests require approval from a +[Code Owner](https://github.com/electron/electron/blob/master/.github/CODEOWNERS) +of the area you modified in order to land. Whenever a maintainer reviews a pull +request they may request changes. These may be small, such as fixing a typo, or +may involve substantive changes. Such requests are intended to be helpful, but +at times may come across as abrupt or unhelpful, especially if they do not include concrete suggestions on *how* to change them. Try not to be discouraged. If you feel that a review is unfair, say so or seek @@ -254,7 +255,6 @@ platforms or for so-called "flaky" tests to fail ("be red"). Each CI failure must be manually inspected to determine the cause. CI starts automatically when you open a pull request, but only -[Releasers](https://github.com/orgs/electron/teams/releasers/members) -can restart a CI run. If you believe CI is giving a false negative, -ask a Releaser to restart the tests. +core maintainers can restart a CI run. If you believe CI is giving a +false negative, ask a maintainer to restart the tests.