docs: fix fiddles (#39060)

* refactor: replace Array.prototype.forEach.call with plain for-of

* fix: add missing contextIsolation: false

* fix: open links in default browser

docs/fiddles/windows/manage-windows/create-frameless-window/main.js

@@ -11,6 +11,7 @@ function createWindow () {
     height: 400,
     title: 'Create a frameless window',
     webPreferences: {
+      contextIsolation: false,
       nodeIntegration: true
     }
   })

docs/fiddles/windows/manage-windows/frameless-window/main.js

@@ -12,6 +12,7 @@ function createWindow () {
     width: 800,
     height: 600,
     webPreferences: {
+      contextIsolation: false,
       nodeIntegration: true
     }
   })

docs/fiddles/windows/manage-windows/frameless-window/renderer.js

@@ -1,4 +1,4 @@
-const { ipcRenderer } = require('electron')
+const { ipcRenderer, shell } = require('electron')
 
 const newWindowBtn = document.getElementById('frameless-window')
 
@@ -6,3 +6,15 @@ newWindowBtn.addEventListener('click', () => {
   const url = 'data:text/html,<h2>Hello World!</h2><a id="close" href="javascript:window.close()">Close this Window</a>'
   ipcRenderer.send('create-frameless-window', { url })
 })
+
+const links = document.querySelectorAll('a[href]')
+
+for (const link of links) {
+  const url = link.getAttribute('href')
+  if (url.indexOf('http') === 0) {
+    link.addEventListener('click', (e) => {
+      e.preventDefault()
+      shell.openExternal(url)
+    })
+  }
+}

docs/fiddles/windows/manage-windows/manage-window-state/main.js

@@ -22,6 +22,7 @@ function createWindow () {
     width: 800,
     height: 600,
     webPreferences: {
+      contextIsolation: false,
       nodeIntegration: true
     }
   })

docs/fiddles/windows/manage-windows/manage-window-state/renderer.js

@@ -14,7 +14,7 @@ manageWindowBtn.addEventListener('click', (event) => {
   ipcRenderer.send('create-demo-window')
 })
 
-Array.prototype.forEach.call(links, (link) => {
+for (const link of links) {
   const url = link.getAttribute('href')
   if (url.indexOf('http') === 0) {
     link.addEventListener('click', (e) => {
@@ -22,4 +22,4 @@ Array.prototype.forEach.call(links, (link) => {
       shell.openExternal(url)
     })
   }
-})
+}

docs/fiddles/windows/manage-windows/new-window/main.js

@@ -12,6 +12,7 @@ function createWindow () {
     width: 800,
     height: 600,
     webPreferences: {
+      contextIsolation: false,
       nodeIntegration: true
     }
   })

docs/fiddles/windows/manage-windows/window-events/main.js

@@ -7,6 +7,7 @@ function createWindow () {
     width: 800,
     height: 600,
     webPreferences: {
+      contextIsolation: false,
       nodeIntegration: true
     }
   })

docs/fiddles/windows/manage-windows/window-events/renderer.js

@@ -28,7 +28,7 @@ listenToWindowBtn.addEventListener('click', () => {
 
 const links = document.querySelectorAll('a[href]')
 
-Array.prototype.forEach.call(links, (link) => {
+for (const link of links) {
   const url = link.getAttribute('href')
   if (url.indexOf('http') === 0) {
     link.addEventListener('click', (e) => {
@@ -36,4 +36,4 @@ Array.prototype.forEach.call(links, (link) => {
       shell.openExternal(url)
     })
   }
-})
+}