github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-04-10 03:01:51 -04:00
Code Issues Packages Projects Releases Wiki Activity

test: fix some failing and disabled node specs (#19518)

Browse Source 
* test: fix some failing and disabled node specs

These tests were failing due to mismatched stacktraces as a result of
our Module._load hook.  This fixes those by adding a flag to optionally
not hook those calls and instead do the asar override eagily.

* ELECTRON_EAGER_ASAR_HOOK => ELECTRON_EAGER_ASAR_HOOK_FOR_TESTING

* test: parallel/test-zlib-unused-weak consistently fails

Co-authored-by: Cheng Zhao <zcbenz@github.com>
This commit is contained in:
Samuel Attard
2020-01-14 23:07:03 -08:00
committed by Cheng Zhao
parent 49262b604d
commit b31c02ef31
3 changed files with 34 additions and 41 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
script/node-disabled-tests.json
View File

@@ -30,36 +30,17 @@
"es-module/test-esm-snapshot",
"es-module/test-esm-specifiers",
"es-module/test-esm-type-flag",
"message/assert_throws_stack",
"message/async_error_eval_esm",
"message/async_error_sync_esm",
"message/console",
"message/core_line_numbers",
"message/error_exit",
"message/esm_display_syntax_error",
"message/esm_display_syntax_error_import",
"message/esm_display_syntax_error_import_module",
"message/esm_display_syntax_error_module",
"message/eval_messages",
"message/events_unhandled_error_common_trace",
"message/events_unhandled_error_nexttick",
"message/events_unhandled_error_sameline",
"message/events_unhandled_error_subclass",
"message/if-error-has-good-stack",
"message/internal_assert",
"message/internal_assert_fail",
"message/promise_always_throw_unhandled",
"message/source_map_throw_catch",
"message/source_map_throw_first_tick",
"message/source_map_throw_set_immediate",
"message/undefined_reference_in_new_context",
"message/unhandled_promise_trace_warnings",
"message/util_inspect_error",
"message/v8_warning",
"message/vm_display_runtime_error",
"message/vm_display_syntax_error",
"message/vm_dont_display_runtime_error",
"message/vm_dont_display_syntax_error",
"parallel/test-assert",
"parallel/test-async-hooks-close-during-destroy",
"parallel/test-async-hooks-promise",