github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-04-10 03:01:51 -04:00
Code Issues Packages Projects Releases Wiki Activity

refactor: use std::map::try_emplace() over std::map::insert() (#46761)

Browse Source 
refactor: prefer std::map::try_emplace() over std::map::insert()
This commit is contained in:
Charles Kerr
2025-04-25 13:11:53 -05:00
committed by GitHub
parent 8fa7d324d1
commit b40b4dc015
10 changed files with 15 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
shell/browser/hid/electron_hid_delegate.cc
View File

@@ -241,8 +241,7 @@ HidChooserController* ElectronHidDelegate::AddControllerForFrame(
auto controller = std::make_unique<HidChooserController>(
render_frame_host, std::move(filters), std::move(exclusion_filters),
std::move(callback), web_contents, weak_factory_.GetWeakPtr());
controller_map_.insert(
std::make_pair(render_frame_host, std::move(controller)));
controller_map_.try_emplace(render_frame_host, std::move(controller));
return ControllerForFrame(render_frame_host);
}

2
shell/browser/hid/hid_chooser_context.cc
View File

@@ -307,7 +307,7 @@ void HidChooserContext::SetUpHidManagerConnection(
void HidChooserContext::InitDeviceList(
std::vector<device::mojom::HidDeviceInfoPtr> devices) {
for (auto& device : devices)
devices_.insert({device->guid, std::move(device)});
devices_.try_emplace(device->guid, std::move(device));
is_initialized_ = true;