From b429e6e2df5c25933ccd6ddc3d2e903be831ff2f Mon Sep 17 00:00:00 2001 From: Samuel Attard Date: Thu, 21 Mar 2019 21:02:40 -0700 Subject: [PATCH] chore: disable clang-format and cpplint for impl of HandleExternalProtocol NOLINT disables the linting error that we can't fix because its just implementing a content API. We also disable clang-format because it tries to format the // NOLINT onto a new line which doesn't exactly work --- atom/browser/atom_browser_client.cc | 4 +++- atom/browser/atom_browser_client.h | 5 ++++- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/atom/browser/atom_browser_client.cc b/atom/browser/atom_browser_client.cc index 60ef875c4d..1006bb9d45 100644 --- a/atom/browser/atom_browser_client.cc +++ b/atom/browser/atom_browser_client.cc @@ -832,7 +832,9 @@ bool AtomBrowserClient::HandleExternalProtocol( const std::string& method, const net::HttpRequestHeaders& headers, network::mojom::URLLoaderFactoryRequest* factory_request, - network::mojom::URLLoaderFactory*& out_factory) { + // clang-format off + network::mojom::URLLoaderFactory*& out_factory) { // NOLINT + // clang-format on base::PostTaskWithTraits( FROM_HERE, {BrowserThread::UI}, base::BindOnce(&HandleExternalProtocolInUI, url, web_contents_getter, diff --git a/atom/browser/atom_browser_client.h b/atom/browser/atom_browser_client.h index dce0ac3da3..9fe2c81854 100644 --- a/atom/browser/atom_browser_client.h +++ b/atom/browser/atom_browser_client.h @@ -174,7 +174,10 @@ class AtomBrowserClient : public content::ContentBrowserClient, const std::string& method, const net::HttpRequestHeaders& headers, network::mojom::URLLoaderFactoryRequest* factory_request, - network::mojom::URLLoaderFactory*& out_factory) override; + // clang-format off + network::mojom::URLLoaderFactory*& out_factory) // NOLINT + // clang-format on + override; private: struct ProcessPreferences {