From b722150d87c696ee27f30a9c579e95776ad0fe44 Mon Sep 17 00:00:00 2001 From: Samuel Attard Date: Tue, 27 Feb 2018 16:13:17 +1100 Subject: [PATCH] Don't cast manually for NativeWindow* --- atom/browser/api/atom_api_browser_window.cc | 7 +------ atom/browser/api/atom_api_browser_window.h | 2 +- 2 files changed, 2 insertions(+), 7 deletions(-) diff --git a/atom/browser/api/atom_api_browser_window.cc b/atom/browser/api/atom_api_browser_window.cc index 0812c61f55..8a1d57c2d6 100644 --- a/atom/browser/api/atom_api_browser_window.cc +++ b/atom/browser/api/atom_api_browser_window.cc @@ -1082,12 +1082,7 @@ void BrowserWindow::ToggleTabBar() { window_->ToggleTabBar(); } -void BrowserWindow::AddTabbedWindow(mate::Arguments* args) { - NativeWindow* window; - if (!args->GetNext(&window)) { - args->ThrowError("Insert good error message here"); - return; - } +void BrowserWindow::AddTabbedWindow(NativeWindow* window, mate::Arguments* args) { window_->AddTabbedWindow(window, args); } diff --git a/atom/browser/api/atom_api_browser_window.h b/atom/browser/api/atom_api_browser_window.h index 55f0edcd07..768d975e46 100644 --- a/atom/browser/api/atom_api_browser_window.h +++ b/atom/browser/api/atom_api_browser_window.h @@ -243,7 +243,7 @@ class BrowserWindow : public mate::TrackableObject, void MergeAllWindows(); void MoveTabToNewWindow(); void ToggleTabBar(); - void AddTabbedWindow(mate::Arguments* args); + void AddTabbedWindow(NativeWindow* window, mate::Arguments* args); void SetVibrancy(mate::Arguments* args); void SetTouchBar(const std::vector& items);