github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-04-10 03:01:51 -04:00
Code Issues Packages Projects Releases Wiki Activity

feat: add menu item role palette and header (#45538)

Browse Source 
* feat: add menu item role `palette` and `header`

* adds comments

* refactors new role items to new item types

* docs: custom type

* docs: note types only available on mac 14+

---------

Co-authored-by: Samuel Maddock <smaddock@slack-corp.com>
This commit is contained in:
Gellert Hegyi
2025-05-23 18:43:49 +02:00
committed by GitHub
parent 2248de847d
commit b9b96a96f7
10 changed files with 61 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
shell/browser/api/electron_api_menu.cc
View File

@@ -213,6 +213,10 @@ void Menu::SetRole(int index, const std::u16string& role) {
model_->SetRole(index, role);
}
void Menu::SetCustomType(int index, const std::u16string& customType) {
model_->SetCustomType(index, customType);
}
void Menu::Clear() {
model_->Clear();
}
@@ -286,6 +290,7 @@ void Menu::FillObjectTemplate(v8::Isolate* isolate,
.SetMethod("setSublabel", &Menu::SetSublabel)
.SetMethod("setToolTip", &Menu::SetToolTip)
.SetMethod("setRole", &Menu::SetRole)
.SetMethod("setCustomType", &Menu::SetCustomType)
.SetMethod("clear", &Menu::Clear)
.SetMethod("getIndexOfCommandId", &Menu::GetIndexOfCommandId)
.SetMethod("getItemCount", &Menu::GetItemCount)

1
shell/browser/api/electron_api_menu.h
View File

@@ -116,6 +116,7 @@ class Menu : public gin::Wrappable<Menu>,
void SetSublabel(int index, const std::u16string& sublabel);
void SetToolTip(int index, const std::u16string& toolTip);
void SetRole(int index, const std::u16string& role);
void SetCustomType(int index, const std::u16string& customType);
void Clear();
int GetIndexOfCommandId(int command_id) const;
int GetItemCount() const;