github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-04-10 03:01:51 -04:00
Code Issues Packages Projects Releases Wiki Activity

build: fix unicode patch file comparison in git.py (#28454)

Browse Source 
This caused some patches to fail incorrectly as the patch file included
non-ascii characters, we have to manually convert using the utf8 charset
This commit is contained in:
Samuel Attard
2021-03-31 13:48:21 -07:00
committed by GitHub
parent bdeeabdc3c
commit ba3b2189ad
1 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
script/lib/git.py
View File

@@ -307,17 +307,19 @@ def export_patches(repo, out_dir, patch_range=None, dry_run=False):
# exported patch differs from what exists. Report number of mismatched
# patches and fail if there's more than one.
patch_count = 0
bad_patches = []
for patch in patches:
filename = get_file_name(patch)
filepath = posixpath.join(out_dir, filename)
existing_patch = io.open(filepath, 'rb').read()
existing_patch = unicode(io.open(filepath, 'rb').read(), "utf-8")
formatted_patch = join_patch(patch)
if formatted_patch != existing_patch:
patch_count += 1
bad_patches.append(filename)
if patch_count > 0:
sys.stderr.write(
"Patches in {} not up to date: {} patches need update\n".format(
out_dir, patch_count
"Patches in {} not up to date: {} patches need update\n-- {}\n".format(
out_dir, patch_count, "\n-- ".join(bad_patches)
)
)
exit(1)