github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-04-10 03:01:51 -04:00
Code Issues Packages Projects Releases Wiki Activity

build: fix native_mksnapshot build (#15770)

Browse Source 
* build: fix native_mksnapshot build

When we changed our electron_mksnapshot_zip target to include the v8_context_snapshot_generator, this dependency made the `run_mksnapshot` target run which was trying to run an arm/arm64 binary on x64 hardware.

Don't use custom build args for native_mksnapshot as they are not needed

* Added comment on why snapshot_blob.bin is skipped on arm/arm64
This commit is contained in:
John Kleinschmidt
2018-11-21 15:19:19 -05:00
committed by GitHub
parent 9e8b26cc4e
commit bb7c63c052
5 changed files with 50 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
build/args/native_mksnapshot.gn
View File

@@ -1,2 +0,0 @@
import("release.gn")
v8_enable_i18n_support = false