github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-04-10 03:01:51 -04:00
Code Issues Packages Projects Releases Wiki Activity

chore: remove native_mate (Part 10) (#20696)

Browse Source 
* refactor: remove direct uses of event_emitter_deprecated.h

* refactor: remove event_emitter_deprecated.h in api::App

* refactor: use std::move to save a copy

* fix: windows and linux builds
This commit is contained in:
Cheng Zhao
2019-10-24 14:47:58 +09:00
committed by GitHub
parent 77414813b4
commit be955a9721
24 changed files with 223 additions and 199 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
shell/browser/browser.cc
View File

@@ -22,6 +22,7 @@
#include "shell/browser/native_window.h"
#include "shell/browser/window_list.h"
#include "shell/common/application_info.h"
#include "shell/common/gin_helper/arguments.h"
namespace electron {
@@ -57,7 +58,7 @@ void Browser::Quit() {
electron::WindowList::CloseAllWindows();
}
void Browser::Exit(mate::Arguments* args) {
void Browser::Exit(gin_helper::Arguments* args) {
int code = 0;
args->GetNext(&code);
@@ -165,14 +166,14 @@ void Browser::DidFinishLaunching(const base::DictionaryValue& launch_info) {
observer.OnFinishLaunching(launch_info);
}
const util::Promise<void*>& Browser::WhenReady(v8::Isolate* isolate) {
v8::Local<v8::Value> Browser::WhenReady(v8::Isolate* isolate) {
if (!ready_promise_) {
ready_promise_ = std::make_unique<util::Promise<void*>>(isolate);
if (is_ready()) {
ready_promise_->Resolve();
}
}
return *ready_promise_;
return ready_promise_->GetHandle();
}
void Browser::OnAccessibilitySupportChanged() {