github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-04-10 03:01:51 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix: reply notifs sometimes destroyed too early (#25086)

Browse Source 
* fix: reply notifs sometimes destroyed too early

* Fix windows build
This commit is contained in:
Shelley Vohr
2020-08-23 21:27:46 -07:00
committed by GitHub
parent a23c66e4e1
commit bea6c9e4e1
4 changed files with 10 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
shell/browser/notifications/mac/notification_center_delegate.mm
View File

@@ -43,7 +43,10 @@
// https://developer.apple.com/documentation/foundation/nsusernotificationactivationtype?language=objc
if (notif.activationType ==
NSUserNotificationActivationTypeContentsClicked) {
notification->NotificationClicked();
// If a notification with a reply button is clicked and the user has not
// yet replied, we do not want to destroy the notification.
bool should_destroy = ![notif hasReplyButton];
notification->NotificationClicked(should_destroy);
} else if (notif.activationType ==
NSUserNotificationActivationTypeActionButtonClicked) {
notification->NotificationActivated();