github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-01-27 00:09:09 -05:00
Code Issues Packages Projects Releases Wiki Activity

feat: improve TouchBarButton accessibility (#20454)

Browse Source
This commit is contained in:
Shelley Vohr
2019-10-08 17:13:57 +02:00
committed by John Kleinschmidt
parent 8da9a3c416
commit c16a186de0
4 changed files with 53 additions and 32 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
shell/browser/ui/cocoa/atom_touch_bar.mm
View File

@@ -363,6 +363,10 @@ static NSString* const ImageScrubberItemIdentifier = @"scrubber.image.item";
button.bezelColor = nil;
}
std::string accessibilityLabel;
settings.Get("accessibilityLabel", &accessibilityLabel);
button.accessibilityLabel = base::SysUTF8ToNSString(accessibilityLabel);
std::string label;
settings.Get("label", &label);
button.title = base::SysUTF8ToNSString(label);
@@ -405,6 +409,10 @@ static NSString* const ImageScrubberItemIdentifier = @"scrubber.image.item";
settings.Get("label", &label);
text_field.stringValue = base::SysUTF8ToNSString(label);
std::string accessibilityLabel;
settings.Get("accessibilityLabel", &accessibilityLabel);
text_field.accessibilityLabel = base::SysUTF8ToNSString(accessibilityLabel);
std::string textColor;
if (settings.Get("textColor", &textColor) && !textColor.empty()) {
text_field.textColor = [self colorFromHexColorString:textColor];