From 3e9f9429d1f3b1e78085e6de505f2140a2f26092 Mon Sep 17 00:00:00 2001 From: Aleksei Kuzmin Date: Sat, 25 Nov 2017 13:21:26 +0100 Subject: [PATCH 1/2] Enable " tag found-in-page event emits when a request is made" Fixes #11244. --- spec/webview-spec.js | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/spec/webview-spec.js b/spec/webview-spec.js index c68a492bbd..0ce043069f 100644 --- a/spec/webview-spec.js +++ b/spec/webview-spec.js @@ -933,9 +933,7 @@ describe(' tag', function () { }) }) - // TODO(alexeykuzmin): Disabled during Chromium 61 upgrade. - // Fix it and enable. - xdescribe('found-in-page event', () => { + describe('found-in-page event', () => { it('emits when a request is made', (done) => { let requestId = null let activeMatchOrdinal = [] From 084292f3ab4c06630700c604a38aa3b8bf6ba09d Mon Sep 17 00:00:00 2001 From: deepak1556 Date: Sat, 25 Nov 2017 20:18:01 +0530 Subject: [PATCH 2/2] fix: focus the webview as a temp workaround --- spec/webview-spec.js | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/spec/webview-spec.js b/spec/webview-spec.js index 0ce043069f..2a9ef8642e 100644 --- a/spec/webview-spec.js +++ b/spec/webview-spec.js @@ -956,6 +956,11 @@ describe(' tag', function () { webview.addEventListener('did-finish-load', listener2) webview.src = `file://${fixtures}/pages/content.html` document.body.appendChild(webview) + // TODO(deepak1556): With https://codereview.chromium.org/2836973002 + // focus of the webContents is required when triggering the api. + // Remove this workaround after determining the cause for + // incorrect focus. + webview.focus() }) })