From c1f32afeeb3b1707b7b2a625ed4e4200b9864f87 Mon Sep 17 00:00:00 2001 From: deepak1556 Date: Thu, 25 Oct 2018 20:50:55 +0530 Subject: [PATCH] Use CompletionOnceCallback in URLRequestSimpleJob. https://chromium-review.googlesource.com/c/chromium/src/+/1155089 --- atom/browser/net/url_request_buffer_job.cc | 2 +- atom/browser/net/url_request_buffer_job.h | 2 +- atom/browser/net/url_request_string_job.cc | 9 ++++----- atom/browser/net/url_request_string_job.h | 2 +- 4 files changed, 7 insertions(+), 8 deletions(-) diff --git a/atom/browser/net/url_request_buffer_job.cc b/atom/browser/net/url_request_buffer_job.cc index 4b25a35e4f..8f2f43f1e7 100644 --- a/atom/browser/net/url_request_buffer_job.cc +++ b/atom/browser/net/url_request_buffer_job.cc @@ -143,7 +143,7 @@ int URLRequestBufferJob::GetRefCountedData( std::string* mime_type, std::string* charset, scoped_refptr* data, - const net::CompletionCallback& callback) const { + net::CompletionOnceCallback callback) const { *mime_type = mime_type_; *charset = charset_; *data = data_; diff --git a/atom/browser/net/url_request_buffer_job.h b/atom/browser/net/url_request_buffer_job.h index 25ca13b310..afebdcf888 100644 --- a/atom/browser/net/url_request_buffer_job.h +++ b/atom/browser/net/url_request_buffer_job.h @@ -31,7 +31,7 @@ class URLRequestBufferJob : public JsAsker, public net::URLRequestSimpleJob { int GetRefCountedData(std::string* mime_type, std::string* charset, scoped_refptr* data, - const net::CompletionCallback& callback) const override; + net::CompletionOnceCallback callback) const override; private: std::string mime_type_; diff --git a/atom/browser/net/url_request_string_job.cc b/atom/browser/net/url_request_string_job.cc index 678fc20b33..a96d595a3b 100644 --- a/atom/browser/net/url_request_string_job.cc +++ b/atom/browser/net/url_request_string_job.cc @@ -102,11 +102,10 @@ void URLRequestStringJob::GetResponseInfo(net::HttpResponseInfo* info) { info->headers = headers; } -int URLRequestStringJob::GetData( - std::string* mime_type, - std::string* charset, - std::string* data, - const net::CompletionCallback& callback) const { +int URLRequestStringJob::GetData(std::string* mime_type, + std::string* charset, + std::string* data, + net::CompletionOnceCallback callback) const { *mime_type = mime_type_; *charset = charset_; *data = data_; diff --git a/atom/browser/net/url_request_string_job.h b/atom/browser/net/url_request_string_job.h index 5fc12e1cb3..48bc9c3fa7 100644 --- a/atom/browser/net/url_request_string_job.h +++ b/atom/browser/net/url_request_string_job.h @@ -29,7 +29,7 @@ class URLRequestStringJob : public JsAsker, public net::URLRequestSimpleJob { int GetData(std::string* mime_type, std::string* charset, std::string* data, - const net::CompletionCallback& callback) const override; + net::CompletionOnceCallback callback) const override; private: std::string mime_type_;