github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-05-02 03:00:22 -04:00
Code Issues Packages Projects Releases Wiki Activity

Write a warning instead of crashing.

Browse Source
This commit is contained in:
Charlie Hess
2017-01-13 12:28:11 -08:00
committed by Kevin Sawicki
parent bc2f1e8199
commit c213971a2d
3 changed files with 15 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
lib/browser/rpc-server.js
View File

@@ -160,6 +160,9 @@ const rendererMissingErrorMessage = (meta, args, callIntoRenderer) => {
if (remoteEvents.length > 0) {
message += `\nRemote event names: ${remoteEvents.join(', ')}`
remoteEvents.forEach((eventName) => {
sender.removeListener(eventName, callIntoRenderer)
})
}
return message
@@ -215,7 +218,7 @@ const unwrapArgs = function (sender, args) {
if (!sender.isDestroyed() && webContentsId === sender.getId()) {
sender.send('ELECTRON_RENDERER_CALLBACK', meta.id, valueToMeta(sender, args))
} else {
throw new Error(rendererMissingErrorMessage(meta, args, callIntoRenderer))
console.warn(rendererMissingErrorMessage(meta, args, callIntoRenderer))
}
}