From c43d6862d32c74f63f82700a7546a732ac05ecb8 Mon Sep 17 00:00:00 2001
From: Charles Kerr <charles@charleskerr.com>
Date: Fri, 9 Aug 2024 13:21:41 -0500
Subject: [PATCH] refactor: in auto_updater::AutoUpdater, move empty function
 decls to header

---
 shell/browser/auto_updater.cc | 6 ------
 shell/browser/auto_updater.h  | 6 +++---
 2 files changed, 3 insertions(+), 9 deletions(-)

diff --git a/shell/browser/auto_updater.cc b/shell/browser/auto_updater.cc
index cd6c9d8676..ab345f1cc1 100644
--- a/shell/browser/auto_updater.cc
+++ b/shell/browser/auto_updater.cc
@@ -22,12 +22,6 @@ std::string AutoUpdater::GetFeedURL() {
   return "";
 }
 
-void AutoUpdater::SetFeedURL(gin::Arguments* args) {}
-
-void AutoUpdater::CheckForUpdates() {}
-
-void AutoUpdater::QuitAndInstall() {}
-
 bool AutoUpdater::IsVersionAllowedForUpdate(const std::string& current_version,
                                             const std::string& target_version) {
   return false;
diff --git a/shell/browser/auto_updater.h b/shell/browser/auto_updater.h
index be2487c22d..f13fc5aad7 100644
--- a/shell/browser/auto_updater.h
+++ b/shell/browser/auto_updater.h
@@ -64,9 +64,9 @@ class AutoUpdater {
   // FIXME(zcbenz): We should not do V8 in this file, this method should only
   // accept C++ struct as parameter, and atom_api_auto_updater.cc is responsible
   // for parsing the parameter from JavaScript.
-  static void SetFeedURL(gin::Arguments* args);
-  static void CheckForUpdates();
-  static void QuitAndInstall();
+  static void SetFeedURL(gin::Arguments* args) {}
+  static void CheckForUpdates() {}
+  static void QuitAndInstall() {}
 
   static bool IsVersionAllowedForUpdate(const std::string& current_version,
                                         const std::string& target_version);