github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-01-09 15:38:08 -05:00
Code Issues Packages Projects Releases Wiki Activity

refactor: remove redundant map lookups in browser/api/menu.ts (#48706)

Browse Source 
perf: avoid double map lookup in Menu.prototype._shouldCommandIdWorkWhenHidden

perf: avoid double map lookup in Menu.prototype._isCommandIdVisible

perf: avoid double map lookup in Menu.prototype._shouldRegisterAcceleratorForCommandId

perf: avoid double map lookup in Menu.prototype._getSharingItemForCommandId
This commit is contained in:
Charles Kerr
2025-10-29 11:42:15 -05:00
committed by GitHub
parent 37de243f55
commit c5fe50be3b
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
lib/browser/api/menu.ts
View File

@@ -46,11 +46,11 @@ Menu.prototype._isCommandIdEnabled = function (id) {
}; };
Menu.prototype._shouldCommandIdWorkWhenHidden = function (id) { Menu.prototype._shouldCommandIdWorkWhenHidden = function (id) {
return this.commandsMap[id] ? !!this.commandsMap[id].acceleratorWorksWhenHidden : false; return this.commandsMap[id]?.acceleratorWorksWhenHidden ?? false;
}; };
Menu.prototype._isCommandIdVisible = function (id) { Menu.prototype._isCommandIdVisible = function (id) {
return this.commandsMap[id] ? this.commandsMap[id].visible : false; return this.commandsMap[id]?.visible ?? false;
}; };
Menu.prototype._getAcceleratorForCommandId = function (id, useDefaultAccelerator) { Menu.prototype._getAcceleratorForCommandId = function (id, useDefaultAccelerator) {
@@ -61,12 +61,12 @@ Menu.prototype._getAcceleratorForCommandId = function (id, useDefaultAccelerator
}; };
Menu.prototype._shouldRegisterAcceleratorForCommandId = function (id) { Menu.prototype._shouldRegisterAcceleratorForCommandId = function (id) {
return this.commandsMap[id] ? this.commandsMap[id].registerAccelerator : false; return this.commandsMap[id]?.registerAccelerator ?? false;
}; };
if (process.platform === 'darwin') { if (process.platform === 'darwin') {
Menu.prototype._getSharingItemForCommandId = function (id) { Menu.prototype._getSharingItemForCommandId = function (id) {
return this.commandsMap[id] ? this.commandsMap[id].sharingItem : null; return this.commandsMap[id]?.sharingItem ?? null;
}; };
} }