github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-01-09 15:38:08 -05:00
Code Issues Packages Projects Releases Wiki Activity

fix: set prototype names on gin::Constructible classes (#39006)

Browse Source 
* fix: set prototype names on gin::Constructible classes

* test: add tests
This commit is contained in:
Shelley Vohr
2023-07-10 11:49:20 +02:00
committed by GitHub
parent 56b5c00312
commit c7bdd907d7
23 changed files with 71 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
shell/browser/api/electron_api_web_contents.cc
View File

@@ -4161,7 +4161,7 @@ void WebContents::FillObjectTemplate(v8::Isolate* isolate,
v8::Local<v8::ObjectTemplate> templ) {
gin::InvokerOptions options;
options.holder_is_first_argument = true;
options.holder_type = "WebContents";
options.holder_type = GetClassName();
templ->Set(
gin::StringToSymbol(isolate, "isDestroyed"),
gin::CreateFunctionTemplate(
@@ -4301,7 +4301,7 @@ void WebContents::FillObjectTemplate(v8::Isolate* isolate,
}
const char* WebContents::GetTypeName() {
return "WebContents";
return GetClassName();
}
ElectronBrowserContext* WebContents::GetBrowserContext() const {