mirror of
https://github.com/electron/electron.git
synced 2026-01-09 15:38:08 -05:00
fix: Showing the about panel is async on all platforms (#37440)
* fix: about panel is a base::Value::Dict * nix this test for a diff PR * what if the about dialog was not blocking * add this test back in * document synchronicity * github editor is a fan of spaces
This commit is contained in:
@@ -1867,6 +1867,10 @@ describe('app module', () => {
|
||||
version: '1.2.3'
|
||||
});
|
||||
});
|
||||
|
||||
it('app.showAboutPanel() does not crash & runs asynchronously', () => {
|
||||
app.showAboutPanel();
|
||||
});
|
||||
});
|
||||
});
|
||||
|
||||
|
||||
Reference in New Issue
Block a user