github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-04-10 03:01:51 -04:00
Code Issues Packages Projects Releases Wiki Activity

chore: add safety checks to RepositionTrafficLights (#21981)

Browse Source
This commit is contained in:
Samuel Attard
2020-01-31 10:27:25 -08:00
committed by GitHub
parent 45f30ead61
commit cabe514431
1 changed files with 6 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
shell/browser/native_window_mac.mm
View File

@@ -523,6 +523,12 @@ void NativeWindowMac::RepositionTrafficLights() {
NSButton* miniaturize =
[window standardWindowButton:NSWindowMiniaturizeButton];
NSButton* zoom = [window standardWindowButton:NSWindowZoomButton];
// Safety check just in case apple changes the view structure in a macOS
// update
DCHECK(close.superview);
DCHECK(close.superview.superview);
if (!close.superview || !close.superview.superview)
return;
NSView* titleBarContainerView = close.superview.superview;
// Hide the container when exiting fullscreen, otherwise traffic light buttons