From ce755483ba175b3d9a98e2ffdde9d810be726c93 Mon Sep 17 00:00:00 2001 From: Samuel Attard Date: Mon, 18 Dec 2017 12:24:13 +1100 Subject: [PATCH] DialogClosedCallback are not const references anymore --- atom/browser/atom_javascript_dialog_manager.cc | 4 ++-- atom/browser/atom_javascript_dialog_manager.h | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/atom/browser/atom_javascript_dialog_manager.cc b/atom/browser/atom_javascript_dialog_manager.cc index 4168be3536..4b22c81fe1 100644 --- a/atom/browser/atom_javascript_dialog_manager.cc +++ b/atom/browser/atom_javascript_dialog_manager.cc @@ -35,7 +35,7 @@ void AtomJavaScriptDialogManager::RunJavaScriptDialog( JavaScriptDialogType dialog_type, const base::string16& message_text, const base::string16& default_prompt_text, - const DialogClosedCallback& callback, + DialogClosedCallback callback, bool* did_suppress_message) { const std::string origin = origin_url.GetOrigin().spec(); if (origin_counts_[origin] == kUserWantsNoMoreDialogs) { @@ -79,7 +79,7 @@ void AtomJavaScriptDialogManager::RunJavaScriptDialog( void AtomJavaScriptDialogManager::RunBeforeUnloadDialog( content::WebContents* web_contents, bool is_reload, - const DialogClosedCallback& callback) { + DialogClosedCallback callback) { bool default_prevented = api_web_contents_->Emit("will-prevent-unload"); callback.Run(default_prevented, base::string16()); return; diff --git a/atom/browser/atom_javascript_dialog_manager.h b/atom/browser/atom_javascript_dialog_manager.h index 0f5e55403b..dffedd91e6 100644 --- a/atom/browser/atom_javascript_dialog_manager.h +++ b/atom/browser/atom_javascript_dialog_manager.h @@ -27,12 +27,12 @@ class AtomJavaScriptDialogManager : public content::JavaScriptDialogManager { content::JavaScriptDialogType dialog_type, const base::string16& message_text, const base::string16& default_prompt_text, - const DialogClosedCallback& callback, + DialogClosedCallback callback, bool* did_suppress_message) override; void RunBeforeUnloadDialog( content::WebContents* web_contents, bool is_reload, - const DialogClosedCallback& callback) override; + DialogClosedCallback callback) override; void CancelDialogs(content::WebContents* web_contents, bool reset_state) override;