github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-04-10 03:01:51 -04:00
Code Issues Packages Projects Releases Wiki Activity

feat: support more color formats for backgroundColor (#33364)

Browse Source 
* feat: support more color formats for backgroundColor

* feat: support more formats in getBackgroundColor

* chore: remove redundant includes

* refactor: differentiate rgb/rgba/hsl/hsla + docs

* chore: address review cleanup comments

* refactor: simple getBackgroundColor

* chore: fix iwyu

* fix: typescript arg

* Update docs/api/browser-view.md

Co-authored-by: Jeremy Rose <jeremya@chromium.org>

* chore: address comments

Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: Jeremy Rose <jeremya@chromium.org>
This commit is contained in:
trop[bot]
2022-03-21 20:06:03 -04:00
committed by GitHub
parent e9fa834757
commit cee4e3707f
13 changed files with 144 additions and 55 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
shell/browser/ui/cocoa/electron_touch_bar.mm
View File

@@ -339,7 +339,7 @@ static NSString* const ImageScrubberItemIdentifier = @"scrubber.image.item";
}
- (NSColor*)colorFromHexColorString:(const std::string&)colorString {
SkColor color = electron::ParseHexColor(colorString);
SkColor color = electron::ParseCSSColor(colorString);
return skia::SkColorToDeviceNSColor(color);
}