github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-04-10 03:01:51 -04:00
Code Issues Packages Projects Releases Wiki Activity

feat: systemPreferences.getColor should return RGBA instead of RGB (#38960)

Browse Source 
* fix: return RGBA hex value from `SystemPreferences.getColor`

* docs: update docs to match changes of last commit

* fix: GetColor on windows now returns RGBA too

* fix: update tests for getColor RGBA on Windows

---------

Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
This commit is contained in:
ILikeTeaALot
2023-09-28 23:56:16 +01:00
committed by GitHub
parent dd7395ebed
commit d002f16157
4 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
spec/api-system-preferences-spec.ts
View File

@@ -17,8 +17,8 @@ describe('systemPreferences module', () => {
}).to.throw('Unknown color: not-a-color');
});
it('returns a hex RGB color string', () => {
expect(systemPreferences.getColor('window')).to.match(/^#[0-9A-F]{6}$/i);
it('returns a hex RGBA color string', () => {
expect(systemPreferences.getColor('window')).to.match(/^#[0-9A-F]{8}$/i);
});
});