github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-04-10 03:01:51 -04:00
Code Issues Packages Projects Releases Wiki Activity

chore: prefer empty() check for readability (#26157)

Browse Source
This commit is contained in:
David Sanders
2020-10-26 11:48:12 -07:00
committed by GitHub
parent b1eec448f0
commit d4112d38de
11 changed files with 15 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
shell/browser/api/electron_api_base_window.cc
View File

@@ -947,7 +947,7 @@ std::vector<v8::Local<v8::Object>> BaseWindow::GetChildWindows() const {
v8::Local<v8::Value> BaseWindow::GetBrowserView(
gin_helper::Arguments* args) const {
if (browser_views_.size() == 0) {
if (browser_views_.empty()) {
return v8::Null(isolate());
} else if (browser_views_.size() == 1) {
auto first_view = browser_views_.begin();

4
shell/browser/api/electron_api_web_contents.cc
View File

@@ -404,7 +404,7 @@ base::string16 GetDefaultPrinterAsync() {
if (printer_name.empty()) {
printing::PrinterList printers;
print_backend->EnumeratePrinters(&printers);
if (printers.size() > 0)
if (!printers.empty())
printer_name = printers.front().printer_name;
}
return base::UTF8ToUTF16(printer_name);
@@ -2175,7 +2175,7 @@ void WebContents::Print(gin::Arguments* args) {
continue;
}
}
if (page_range_list.GetList().size() > 0)
if (!page_range_list.GetList().empty())
settings.SetPath(printing::kSettingPageRange, std::move(page_range_list));
}