github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-01-09 15:38:08 -05:00
Code Issues Packages Projects Releases Wiki Activity

refactor: follow upstream's suggestions on when to use EmptyGURL() (#45498)

Browse Source 
- Prefer GURL() when we want to return a non-reference empty URL.

- In ServiceWorkerMain::GetStorageKey(), use a reference instead
  of instantiating a new temporary GURL.

From url/gurl.h:

> // Returns a reference to a singleton empty GURL. This object is for
> // callers who return references but don't have anything to return in
> // some cases. If you just want an empty URL for normal use, prefer
> // GURL().
This commit is contained in:
Charles Kerr
2025-02-07 12:58:31 -06:00
committed by GitHub
parent 3db691804b
commit d7c6fb8250
3 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
shell/browser/api/electron_api_service_worker_main.cc
View File

@@ -192,7 +192,7 @@ bool ServiceWorkerMain::IsDestroyed() const {
}
const blink::StorageKey ServiceWorkerMain::GetStorageKey() {
GURL scope = version_info_ ? version_info()->scope : GURL::EmptyGURL();
const GURL& scope = version_info_ ? version_info()->scope : GURL::EmptyGURL();
return blink::StorageKey::CreateFirstParty(url::Origin::Create(scope));
}
@@ -279,7 +279,7 @@ int64_t ServiceWorkerMain::VersionID() const {
GURL ServiceWorkerMain::ScopeURL() const {
if (version_destroyed_)
return GURL::EmptyGURL();
return {};
return version_info()->scope;
}