github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-05-02 03:00:22 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix: throw error when inserting menu items out-of-range (#17401)

Browse Source 
* fix: throw error when inserting menu items out-of-range

* also check pos < 0
This commit is contained in:
Shelley Vohr
2019-03-18 07:58:42 -07:00
committed by GitHub
parent f09f43a4a9
commit db29978fe0
2 changed files with 24 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
lib/browser/api/menu.js
View File

@@ -110,6 +110,12 @@ Menu.prototype.insert = function (pos, item) {
throw new TypeError('Invalid item')
}
if (pos < 0) {
throw new RangeError(`Position ${pos} cannot be less than 0`)
} else if (pos > this.getItemCount()) {
throw new RangeError(`Position ${pos} cannot be greater than the total MenuItem count`)
}
// insert item depending on its type
insertItemByType.call(this, item, pos)