github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-04-10 03:01:51 -04:00
Code Issues Packages Projects Releases Wiki Activity

refactor: allocate api::App on cpp heap (#48118)

Browse Source
This commit is contained in:
Robo
2025-08-20 20:35:08 +09:00
committed by GitHub
parent d4b7d9e9cf
commit dd54e84a58
7 changed files with 133 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
shell/common/node_bindings.cc
View File

@@ -377,9 +377,18 @@ bool IsAllowedOption(const std::string_view option) {
"--no-experimental-global-navigator",
});
// This should be aligned with what's possible to set via the process object.
static constexpr auto unpacked_options =
base::MakeFixedFlatSet<std::string_view>({
"--expose-internals",
});
if (debug_options.contains(option))
return electron::fuses::IsNodeCliInspectEnabled();
if (unpacked_options.contains(option))
return !electron::api::App::IsPackaged();
return options.contains(option);
}
@@ -601,6 +610,7 @@ void NodeBindings::Initialize(v8::Isolate* const isolate,
node::per_process::cli_options->disable_wasm_trap_handler = true;
uint64_t process_flags =
node::ProcessInitializationFlags::kNoInitializeCppgc |
node::ProcessInitializationFlags::kNoInitializeV8 |
node::ProcessInitializationFlags::kNoInitializeNodeV8Platform;
@@ -610,8 +620,7 @@ void NodeBindings::Initialize(v8::Isolate* const isolate,
process_flags |= node::ProcessInitializationFlags::kEnableStdioInheritance;
if (browser_env_ == BrowserEnvironment::kRenderer)
process_flags |= node::ProcessInitializationFlags::kNoInitializeCppgc |
node::ProcessInitializationFlags::kNoDefaultSignalHandling;
process_flags |= node::ProcessInitializationFlags::kNoDefaultSignalHandling;
if (!fuses::IsNodeOptionsEnabled())
process_flags |= node::ProcessInitializationFlags::kDisableNodeOptionsEnv;