github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-04-10 03:01:51 -04:00
Code Issues Packages Projects Releases Wiki Activity

refactor: ginify Session (#23569)

Browse Source
This commit is contained in:
Jeremy Apthorp
2020-05-19 10:18:12 -07:00
committed by GitHub
parent 3f3a760a01
commit de44d28c8e
11 changed files with 135 additions and 111 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
lib/browser/api/net.ts
View File

@@ -2,7 +2,6 @@ import * as url from 'url';
import { Readable, Writable } from 'stream';
import { app } from 'electron';
import { ClientRequestConstructorOptions, UploadProgress } from 'electron/main';
const { Session } = process.electronBinding('session');
const { net, Net, isValidHeaderName, isValidHeaderValue, createURLLoader } = process.electronBinding('net');
const kSupportedProtocols = new Set(['http:', 'https:']);
@@ -250,7 +249,8 @@ function parseOptions (optionsIn: ClientRequestConstructorOptions | string): Nod
}
}
if (options.session) {
if (options.session instanceof Session) {
// Weak check, but it should be enough to catch 99% of accidental misuses.
if (options.session.constructor && options.session.constructor.name === 'Session') {
urlLoaderOptions.session = options.session;
} else {
throw new TypeError('`session` should be an instance of the Session class');

8
lib/browser/api/session.js
View File

@@ -2,7 +2,7 @@
const { EventEmitter } = require('events');
const { app, deprecate } = require('electron');
const { fromPartition, Session } = process.electronBinding('session');
const { fromPartition } = process.electronBinding('session');
// Public API.
Object.defineProperties(exports, {
@@ -15,9 +15,3 @@ Object.defineProperties(exports, {
value: fromPartition
}
});
Object.setPrototypeOf(Session.prototype, EventEmitter.prototype);
Session.prototype._init = function () {
app.emit('session-created', this);
};