github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-04-10 03:01:51 -04:00
Code Issues Packages Projects Releases Wiki Activity

chore: remove unused and broken ipcRendererInternal.sendTo() (#29743)

Browse Source
This commit is contained in:
Milan Burda
2021-06-18 06:26:18 +02:00
committed by GitHub
parent 6b4c59b8d8
commit de6696ef1d
10 changed files with 12 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
shell/browser/api/electron_api_web_contents.cc
View File

@@ -1601,8 +1601,7 @@ void WebContents::MessageSync(
internal, channel, std::move(arguments));
}
void WebContents::MessageTo(bool internal,
int32_t web_contents_id,
void WebContents::MessageTo(int32_t web_contents_id,
const std::string& channel,
blink::CloneableMessage arguments) {
TRACE_EVENT1("electron", "WebContents::MessageTo", "channel", channel);
@@ -1617,7 +1616,7 @@ void WebContents::MessageTo(bool internal,
WebFrameMain::From(JavascriptEnvironment::GetIsolate(), frame);
int32_t sender_id = ID();
web_frame_main->GetRendererApi()->Message(internal, channel,
web_frame_main->GetRendererApi()->Message(false /* internal */, channel,
std::move(arguments), sender_id);
}
}

3
shell/browser/api/electron_api_web_contents.h
View File

@@ -410,8 +410,7 @@ class WebContents : public gin::Wrappable<WebContents>,
blink::CloneableMessage arguments,
electron::mojom::ElectronBrowser::MessageSyncCallback callback,
content::RenderFrameHost* render_frame_host);
void MessageTo(bool internal,
int32_t web_contents_id,
void MessageTo(int32_t web_contents_id,
const std::string& channel,
blink::CloneableMessage arguments);
void MessageHost(const std::string& channel,