From de93b30d3ce36de74404c4a9220326f41e79bfcb Mon Sep 17 00:00:00 2001 From: Cheng Zhao Date: Tue, 2 Jan 2018 17:02:12 +0900 Subject: [PATCH] win: Fix assertion when getting exe version --- atom/browser/browser_win.cc | 2 ++ 1 file changed, 2 insertions(+) diff --git a/atom/browser/browser_win.cc b/atom/browser/browser_win.cc index eba01ad9b0..1a0c3430ff 100644 --- a/atom/browser/browser_win.cc +++ b/atom/browser/browser_win.cc @@ -20,6 +20,7 @@ #include "base/strings/string_util.h" #include "base/strings/stringprintf.h" #include "base/strings/utf_string_conversions.h" +#include "base/threading/thread_restrictions.h" #include "base/win/registry.h" #include "base/win/win_util.h" #include "base/win/windows_version.h" @@ -334,6 +335,7 @@ PCWSTR Browser::GetAppUserModelID() { std::string Browser::GetExecutableFileVersion() const { base::FilePath path; if (PathService::Get(base::FILE_EXE, &path)) { + base::ThreadRestrictions::ScopedAllowIO allow_io; std::unique_ptr version_info( FileVersionInfo::CreateFileVersionInfo(path)); return base::UTF16ToUTF8(version_info->product_version());