From dfd7598d485b7dfd585bd9f645b85946c71dfed7 Mon Sep 17 00:00:00 2001 From: Felix Rieseberg Date: Mon, 11 Dec 2017 13:54:43 -0800 Subject: [PATCH] :construction_worker: Hence, better testing --- spec/api-menu-spec.js | 31 ++++++++++++++++++++++++++++--- 1 file changed, 28 insertions(+), 3 deletions(-) diff --git a/spec/api-menu-spec.js b/spec/api-menu-spec.js index f57617b877..3c6353db0c 100644 --- a/spec/api-menu-spec.js +++ b/spec/api-menu-spec.js @@ -283,19 +283,44 @@ describe('Menu module', () => { }) it('returns immediately', () => { - menu.popup(w, {x: 100, y: 100}) + const { browserWindow, x, y } = menu.popup(w, {x: 100, y: 100}) + + assert.equal(browserWindow, w) + assert.equal(x, 100) + assert.equal(y, 100) + menu.closePopup(w) }) it('works without a given BrowserWindow and options', () => { - menu.popup({x: 100, y: 100}) + const { browserWindow, x, y } = menu.popup({x: 100, y: 100}) + + assert.equal(browserWindow.constructor.name, 'BrowserWindow') + assert.equal(x, 100) + assert.equal(y, 100) + menu.closePopup() }) it('works without a given BrowserWindow', () => { - menu.popup(100, 100) + const { browserWindow, x, y } = menu.popup(100, 100) + + assert.equal(browserWindow.constructor.name, 'BrowserWindow') + assert.equal(x, 100) + assert.equal(y, 100) + menu.closePopup() }) + + it('works with a given BrowserWindow and no options', () => { + const { browserWindow, x, y } = menu.popup(w, 100, 100) + + assert.equal(browserWindow, w) + assert.equal(x, 100) + assert.equal(y, 100) + + menu.closePopup(w) + }) }) describe('Menu.setApplicationMenu', () => {