github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-04-10 03:01:51 -04:00
Code Issues Packages Projects Releases Wiki Activity

feat: make trafficLightPosition work for customButtonOnHover (#26789)

Browse Source
This commit is contained in:
Cheng Zhao
2020-12-16 14:30:39 +09:00
committed by GitHub
parent 1e2a2004e9
commit e01b1831d9
6 changed files with 76 additions and 45 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
shell/browser/api/electron_api_base_window.cc
View File

@@ -842,11 +842,16 @@ void BaseWindow::SetVibrancy(v8::Isolate* isolate, v8::Local<v8::Value> value) {
#if defined(OS_MAC)
void BaseWindow::SetTrafficLightPosition(const gfx::Point& position) {
window_->SetTrafficLightPosition(position);
// For backward compatibility we treat (0, 0) as reseting to default.
if (position.IsOrigin())
window_->SetTrafficLightPosition(base::nullopt);
else
window_->SetTrafficLightPosition(position);
}
gfx::Point BaseWindow::GetTrafficLightPosition() const {
return window_->GetTrafficLightPosition();
// For backward compatibility we treat default value as (0, 0).
return window_->GetTrafficLightPosition().value_or(gfx::Point());
}
#endif