github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-01-09 15:38:08 -05:00
Code Issues Packages Projects Releases Wiki Activity

build: drop dugite as a dependency (#49194)

Browse Source
This commit is contained in:
John Kleinschmidt
2025-12-12 13:43:12 -05:00
committed by GitHub
parent a486185e10
commit e181fd040f
10 changed files with 94 additions and 66 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
spec/release-notes-spec.ts
View File

@@ -1,12 +1,12 @@
import { expect } from 'chai';
import { GitProcess, IGitExecutionOptions, IGitResult } from 'dugite';
import * as sinon from 'sinon';
import { SpawnSyncReturns } from 'node:child_process';
import * as path from 'node:path';
import * as notes from '../script/release/notes/notes';
/* Fake a Dugite GitProcess that only returns the specific
/* Fake a git spawnSync that only returns the specific
commits that we want to test */
class Commit {
@@ -43,10 +43,10 @@ class GitFake {
}
// eslint-disable-next-line @typescript-eslint/no-unused-vars
exec (args: string[], path: string, options?: IGitExecutionOptions | undefined): Promise<IGitResult> {
exec (command: string, args: string[], options?: any): SpawnSyncReturns<string> {
let stdout = '';
const stderr = '';
const exitCode = 0;
const status = 0;
if (args.length === 3 && args[0] === 'merge-base') {
// expected form: `git merge-base branchName1 branchName2`
@@ -78,10 +78,10 @@ class GitFake {
// git branch --all --contains ${ref} --sort version:refname
stdout = args[3];
} else {
console.error('unhandled GitProcess.exec():', args);
console.error('unhandled git spawnSync():', args);
}
return Promise.resolve({ exitCode, stdout, stderr });
return { status, stdout, stderr, pid: 0, output: [null, stdout, stderr], signal: null };
}
}
@@ -118,8 +118,14 @@ describe('release notes', () => {
});
beforeEach(() => {
const wrapper = (args: string[], path: string, options?: IGitExecutionOptions | undefined) => gitFake.exec(args, path, options);
sandbox.replace(GitProcess, 'exec', wrapper);
const wrapper = (command: unknown, args: unknown, options?: unknown) => {
if (command === 'git' && Array.isArray(args)) {
return gitFake.exec(command as string, args as string[], options);
}
// Default behavior for non-git commands
return { status: 0, stdout: '', stderr: '', pid: 0, output: [null, '', ''], signal: null };
};
sandbox.stub(require('node:child_process'), 'spawnSync').callsFake(wrapper);
gitFake.setBranch(oldBranch, [...sharedHistory, oldFix]);
});

19
spec/version-bump-spec.ts
View File

@@ -1,7 +1,8 @@
import { expect } from 'chai';
import { GitProcess, IGitExecutionOptions, IGitResult } from 'dugite';
import * as sinon from 'sinon';
import { SpawnSyncReturns } from 'node:child_process';
import { ifdescribe } from './lib/spec-helpers';
import { nextVersion } from '../script/release/version-bumper';
@@ -33,10 +34,10 @@ class GitFake {
}
// eslint-disable-next-line @typescript-eslint/no-unused-vars
exec (args: string[], path: string, options?: IGitExecutionOptions | undefined): Promise<IGitResult> {
exec (command: string, args: string[], options?: any): SpawnSyncReturns<string> {
let stdout = '';
const stderr = '';
const exitCode = 0;
const status = 0;
// handle for promoting from current master HEAD
let branch = 'stable';
@@ -48,7 +49,7 @@ class GitFake {
if (!this.branches[branch]) this.setBranch(branch);
stdout = this.branches[branch].join('\n');
return Promise.resolve({ exitCode, stdout, stderr });
return { status, stdout, stderr, pid: 0, output: [null, stdout, stderr], signal: null };
}
}
@@ -163,8 +164,14 @@ describe('version-bumper', () => {
const gitFake = new GitFake();
beforeEach(() => {
const wrapper = (args: string[], path: string, options?: IGitExecutionOptions | undefined) => gitFake.exec(args, path, options);
sandbox.replace(GitProcess, 'exec', wrapper);
const wrapper = (command: unknown, args: unknown, options?: unknown) => {
if (command === 'git' && Array.isArray(args)) {
return gitFake.exec(command as string, args as string[], options);
}
// Default behavior for non-git commands
return { status: 0, stdout: '', stderr: '', pid: 0, output: [null, '', ''], signal: null };
};
sandbox.stub(require('node:child_process'), 'spawnSync').callsFake(wrapper);
});
afterEach(() => {