From 7bd9f2e5d07eb7a38912ddeb6f64379d6032161e Mon Sep 17 00:00:00 2001 From: Cheng Zhao Date: Thu, 24 Dec 2015 12:43:07 +0800 Subject: [PATCH] Fix converting string to NSURL --- atom/common/platform_util_mac.mm | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/atom/common/platform_util_mac.mm b/atom/common/platform_util_mac.mm index dcf622feb5..7184593ae1 100644 --- a/atom/common/platform_util_mac.mm +++ b/atom/common/platform_util_mac.mm @@ -12,6 +12,7 @@ #include "base/mac/mac_logging.h" #include "base/mac/scoped_aedesc.h" #include "base/strings/sys_string_conversions.h" +#include "net/base/mac/url_conversions.h" #include "url/gurl.h" namespace platform_util { @@ -120,9 +121,7 @@ void OpenItem(const base::FilePath& full_path) { bool OpenExternal(const GURL& url) { DCHECK([NSThread isMainThread]); - NSString* url_string = base::SysUTF8ToNSString(url.spec()); - NSString* url_escaped_string = [url_string stringByAddingPercentEscapesUsingEncoding:NSUTF8StringEncoding]; - NSURL* ns_url = [NSURL URLWithString:url_escaped_string]; + NSURL* ns_url = net::NSURLWithGURL(url); if (!ns_url) { return false; }