github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-04-10 03:01:51 -04:00
Code Issues Packages Projects Releases Wiki Activity

refactor: declare gin::Wrapper subclasses as final (#43783)

Browse Source 
refactor: declare gin::Wrapper subclasses as final (#43527)

As per the gin docs: "Wrappable<T> explicitly does not support further
subclassing of T. Subclasses of Wrappable<T> should be declared final."
This commit is contained in:
Charles Kerr
2024-09-19 02:57:24 -05:00
committed by GitHub
parent ea3c48e7c1
commit e62c322b2d
35 changed files with 106 additions and 103 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
shell/renderer/api/electron_api_ipc_renderer.cc
View File

@@ -41,8 +41,8 @@ RenderFrame* GetCurrentRenderFrame() {
return RenderFrame::FromWebFrame(frame);
}
class IPCRenderer : public gin::Wrappable<IPCRenderer>,
public content::RenderFrameObserver {
class IPCRenderer final : public gin::Wrappable<IPCRenderer>,
public content::RenderFrameObserver {
public:
static gin::WrapperInfo kWrapperInfo;

4
shell/renderer/api/electron_api_web_frame.cc
View File

@@ -329,8 +329,8 @@ class SpellCheckerHolder final : public content::RenderFrameObserver {
} // namespace
class WebFrameRenderer : public gin::Wrappable<WebFrameRenderer>,
public content::RenderFrameObserver {
class WebFrameRenderer final : public gin::Wrappable<WebFrameRenderer>,
public content::RenderFrameObserver {
public:
static gin::WrapperInfo kWrapperInfo;