From e6844a3640e8c0e9fb720f7272bda912c641bb80 Mon Sep 17 00:00:00 2001 From: David Sanders Date: Tue, 25 Nov 2025 10:04:52 -0800 Subject: [PATCH] test: remove already disabled nan tests from our disable list (#49050) --- script/nan-spec-runner.js | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/script/nan-spec-runner.js b/script/nan-spec-runner.js index 8fc48ba0f7..f54da087e4 100644 --- a/script/nan-spec-runner.js +++ b/script/nan-spec-runner.js @@ -133,12 +133,7 @@ async function main () { const DISABLED_TESTS = new Set([ 'nannew-test.js', - 'buffer-test.js', - // These two are incompatible with crrev.com/c/4733273 - // They are disabled upstream starting in "Node.js 24" (note: the incompatible change above - // landed in V8 v13.7), so we can remove them from this list once we upgrade Node.js to 24. - 'weak-test.js', - 'weak2-test.js' + 'buffer-test.js' ]); const testsToRun = fs.readdirSync(path.resolve(NAN_DIR, 'test', 'js')) .filter(test => !DISABLED_TESTS.has(test))