fix: free IsolateData in ~NodeEnvironment (#28469)

This seems to just have been missing here, leaking memory
(and breaking the API contract for Node.js embedding).
This commit is contained in:
Anna Henningsen
2021-04-02 01:46:11 +02:00
committed by GitHub
parent fa65faa4b0
commit e6aefed0ee

View File

@@ -363,7 +363,9 @@ void JavascriptEnvironment::OnMessageLoopDestroying() {
NodeEnvironment::NodeEnvironment(node::Environment* env) : env_(env) {}
NodeEnvironment::~NodeEnvironment() {
auto* isolate_data = env_->isolate_data();
node::FreeEnvironment(env_);
node::FreeIsolateData(isolate_data);
}
} // namespace electron