chore: more iwyu (#43063)

* chore: iwyu shell/browser/electron_pdf_document_helper_client.h

* chore: iwyu shell/browser/hid/electron_hid_delegate.h

* chore: iwyu content/public/browser/web_contents.h

* chore: iwyu shell/browser/usb/electron_usb_delegate.h

* chore: iwyu shell/browser/browser_observer.h

* chore: iwyu shell/browser/bluetooth/electron_bluetooth_delegate.h

* chore: iwyu shell/browser/serial/electron_serial_delegate.h

* chore: iwyu shell/browser/api/frame_subscriber.h

* chore: iwyu mojo/public/cpp/bindings/

* chore: iwyu components/

* chore: iwyu extensions/

* chore: iwyu shell/common/gin_helper/

* chore: iwyu v8/

* chore: iwyu base/containers/linked_list.h

* chore: iwyu shell/browser/native_window.h

* chore: iwyu shell/browser/api/electron_api_base_window.h

* chore: iwyu shell/common/node_includes.h

* chore: iwyu gin/handle.h

* chore: iwyu base/functional/callback.h

* chore: iwyu ui/gfx/

* chore: iwyu content/public/browser/render_frame_host.h

* fix: mac

* fix: mac

* fix: win

* chore: iwyu base/files/file_path.h

* chore: iwyu base/unguessable_token.h

* chore: iwyu ui/display/screen.h

* chore: iwyu chrome/browser/predictors/preconnect_manager.h

* chore: iwyu base/observer_list_types.h

* chore: iwyu content/public/browser/web_contents.h

* chore: iwyu chrome/browser/devtools/devtools_eye_dropper.h

* chore: iwyu shell/browser/ui/inspectable_web_contents.h

* chore: iwyu content/public/browser/keyboard_event_processing_result.h

* chore: iwyu net/cookies/canonical_cookie.h

* chore: iwyu net/base/address_list.h

* chore: iwyu net/cert/x509_certificate.h

* chore: iwyu net/cookies/cookie_change_dispatcher.h

* chore: iwyu net/dns/public/host_resolver_results.h

* fix: mac

* Revert "chore: iwyu net/cert/x509_certificate.h"

This reverts commit 002896f71146e90f1e29e090a1d6eede48cee11e.

shell/browser/ui/autofill_popup.cc

@@ -9,6 +9,7 @@
 #include "base/feature_list.h"
 #include "base/i18n/rtl.h"
 #include "components/autofill/core/common/autofill_features.h"
+#include "content/public/browser/render_frame_host.h"
 #include "electron/buildflags/buildflags.h"
 #include "mojo/public/cpp/bindings/associated_remote.h"
 #include "shell/browser/osr/osr_render_widget_host_view.h"

shell/browser/ui/autofill_popup.h

@@ -8,13 +8,19 @@
 #include <vector>
 
 #include "base/memory/raw_ptr.h"
-#include "content/public/browser/render_frame_host.h"
 #include "shell/browser/ui/views/autofill_popup_view.h"
-#include "ui/color/color_id.h"
 #include "ui/gfx/font_list.h"
 #include "ui/views/view.h"
 #include "ui/views/widget/widget.h"
 
+namespace content {
+class RenderFrameHost;
+}  // namespace content
+
+namespace ui {
+using ColorId = int;
+}  // namespace ui
+
 namespace electron {
 
 class AutofillPopupView;

shell/browser/ui/certificate_trust.h

@@ -8,12 +8,17 @@
 #include <string>
 
 #include "net/cert/x509_certificate.h"
-#include "shell/common/gin_helper/promise.h"
 
 namespace electron {
 class NativeWindow;
 }
 
+namespace v8 {
+class Promise;
+template <typename T>
+class Local;
+}  // namespace v8
+
 namespace certificate_trust {
 
 v8::Local<v8::Promise> ShowCertificateTrust(

shell/browser/ui/certificate_trust_mac.mm

@@ -16,6 +16,7 @@
 #include "net/cert/x509_util_apple.h"
 #include "shell/browser/javascript_environment.h"
 #include "shell/browser/native_window.h"
+#include "shell/common/gin_helper/promise.h"
 
 @interface TrustDelegate : NSObject {
  @private

shell/browser/ui/certificate_trust_win.cc

@@ -11,6 +11,7 @@
 #include "net/cert/cert_database.h"
 #include "net/cert/x509_util_win.h"
 #include "shell/browser/javascript_environment.h"
+#include "shell/common/gin_helper/promise.h"
 
 namespace certificate_trust {
 

shell/browser/ui/cocoa/electron_bundle_mover.h

@@ -6,12 +6,15 @@
 #define ELECTRON_SHELL_BROWSER_UI_COCOA_ELECTRON_BUNDLE_MOVER_H_
 
 #include "base/apple/foundation_util.h"
-#include "shell/common/gin_helper/error_thrower.h"
 
 namespace gin {
 class Arguments;
 }
 
+namespace gin_helper {
+class ErrorThrower;
+}  // namespace gin_helper
+
 namespace electron {
 
 // Possible bundle movement conflicts

shell/browser/ui/cocoa/electron_bundle_mover.mm

@@ -16,6 +16,7 @@
 #include "gin/dictionary.h"
 #include "shell/browser/browser.h"
 #include "shell/common/gin_converters/callback_converter.h"
+#include "shell/common/gin_helper/error_thrower.h"
 
 namespace gin {
 

shell/browser/ui/cocoa/electron_touch_bar.h

@@ -12,9 +12,12 @@
 #include <vector>
 
 #include "base/memory/raw_ptr.h"
-#include "shell/browser/native_window.h"
 #include "shell/common/gin_helper/persistent_dictionary.h"
 
+namespace electron {
+class NativeWindow;
+}  // namespace electron
+
 @interface ElectronTouchBar : NSObject <NSScrubberDelegate,
                                         NSScrubberDataSource,
                                         NSScrubberFlowLayoutDelegate> {

shell/browser/ui/cocoa/electron_touch_bar.mm

@@ -10,8 +10,11 @@
 
 #include "base/strings/sys_string_conversions.h"
 #include "shell/browser/javascript_environment.h"
+#include "shell/browser/native_window.h"
 #include "shell/common/color_util.h"
 #include "shell/common/gin_converters/image_converter.h"
+#include "shell/common/gin_helper/dictionary.h"
+#include "shell/common/gin_helper/persistent_dictionary.h"
 #include "skia/ext/skia_utils_mac.h"
 #include "ui/gfx/image/image.h"
 

shell/browser/ui/file_dialog.h

@@ -11,13 +11,17 @@
 
 #include "base/files/file_path.h"
 #include "base/memory/raw_ptr_exclusion.h"
-#include "shell/common/gin_helper/dictionary.h"
-#include "shell/common/gin_helper/promise.h"
 
 namespace electron {
 class NativeWindow;
 }
 
+namespace gin_helper {
+class Dictionary;
+template <typename T>
+class Promise;
+}  // namespace gin_helper
+
 namespace file_dialog {
 
 // <description, extensions>

shell/browser/ui/file_dialog_linux.cc

@@ -14,6 +14,8 @@
 #include "shell/browser/ui/file_dialog.h"
 #include "shell/common/gin_converters/callback_converter.h"
 #include "shell/common/gin_converters/file_path_converter.h"
+#include "shell/common/gin_helper/dictionary.h"
+#include "shell/common/gin_helper/promise.h"
 #include "ui/gtk/select_file_dialog_linux_gtk.h"  // nogncheck
 #include "ui/shell_dialogs/select_file_dialog.h"
 #include "ui/shell_dialogs/selected_file_info.h"

shell/browser/ui/file_dialog_mac.mm

@@ -21,6 +21,8 @@
 #include "content/public/browser/browser_thread.h"
 #include "shell/browser/native_window.h"
 #include "shell/common/gin_converters/file_path_converter.h"
+#include "shell/common/gin_helper/dictionary.h"
+#include "shell/common/gin_helper/promise.h"
 #include "shell/common/thread_restrictions.h"
 
 @interface PopUpButtonHandler : NSObject

shell/browser/ui/file_dialog_win.cc

@@ -22,6 +22,8 @@
 #include "shell/browser/native_window_views.h"
 #include "shell/browser/ui/win/dialog_thread.h"
 #include "shell/common/gin_converters/file_path_converter.h"
+#include "shell/common/gin_helper/dictionary.h"
+#include "shell/common/gin_helper/promise.h"
 
 namespace file_dialog {
 

shell/browser/ui/gtk/menu_util.h

@@ -9,7 +9,7 @@
 
 #include <string>
 
-#include "base/functional/callback.h"
+#include "base/functional/callback_forward.h"
 #include "ui/base/glib/scoped_gsignal.h"
 
 namespace gfx {

shell/browser/ui/inspectable_web_contents_view.h

@@ -10,11 +10,19 @@
 
 #include "base/memory/raw_ptr.h"
 #include "electron/shell/common/api/api.mojom.h"
-#include "ui/gfx/geometry/rounded_corners_f.h"
+
+#if defined(TOOLKIT_VIEWS) && !BUILDFLAG(IS_MAC)
+#include "ui/views/view.h"
+#else
 #include "ui/gfx/native_widget_types.h"
+#endif
 
 class DevToolsContentsResizingStrategy;
 
+namespace gfx {
+class RoundedCornersF;
+}  // namespace gfx
+
 #if defined(TOOLKIT_VIEWS)
 namespace views {
 class View;

shell/browser/ui/inspectable_web_contents_view_mac.mm

@@ -9,6 +9,7 @@
 #import "shell/browser/ui/cocoa/electron_inspectable_web_contents_view.h"
 #include "shell/browser/ui/inspectable_web_contents.h"
 #include "shell/browser/ui/inspectable_web_contents_view_delegate.h"
+#include "ui/gfx/geometry/rounded_corners_f.h"
 
 namespace electron {
 

shell/browser/ui/views/autofill_popup_view.cc

@@ -10,6 +10,7 @@
 #include "base/functional/bind.h"
 #include "base/i18n/rtl.h"
 #include "cc/paint/skia_paint_canvas.h"
+#include "content/public/browser/render_frame_host.h"
 #include "content/public/browser/render_view_host.h"
 #include "ui/accessibility/ax_enums.mojom.h"
 #include "ui/base/dragdrop/drag_drop_types.h"

shell/browser/ui/views/autofill_popup_view.h

@@ -11,7 +11,6 @@
 #include "shell/browser/ui/autofill_popup.h"
 
 #include "base/memory/raw_ptr.h"
-#include "components/input/native_web_keyboard_event.h"
 #include "content/public/browser/render_widget_host.h"
 #include "electron/buildflags/buildflags.h"
 #include "shell/browser/osr/osr_view_proxy.h"
@@ -22,6 +21,10 @@
 #include "ui/views/widget/widget_delegate.h"
 #include "ui/views/widget/widget_observer.h"
 
+namespace input {
+struct NativeWebKeyboardEvent;
+}  // namespace input
+
 namespace ui {
 struct AXNodeData;
 }

shell/browser/ui/views/inspectable_web_contents_view_views.cc

@@ -14,6 +14,7 @@
 #include "shell/browser/ui/inspectable_web_contents_delegate.h"
 #include "shell/browser/ui/inspectable_web_contents_view_delegate.h"
 #include "ui/base/models/image_model.h"
+#include "ui/gfx/geometry/rounded_corners_f.h"
 #include "ui/views/controls/label.h"
 #include "ui/views/controls/webview/webview.h"
 #include "ui/views/widget/widget.h"