github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-04-10 03:01:51 -04:00
Code Issues Packages Projects Releases Wiki Activity

refactor: use gin::Wrappable for electron::api::Screen (#49506)

Browse Source
This commit is contained in:
Charles Kerr
2026-01-25 13:46:25 -06:00
committed by GitHub
parent d5de8883a2
commit e8250f9955
3 changed files with 32 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
shell/browser/api/electron_api_screen.h
View File

@@ -8,8 +8,8 @@
#include <vector>
#include "base/memory/raw_ptr.h"
#include "gin/wrappable.h"
#include "shell/browser/event_emitter_mixin.h"
#include "shell/common/gin_helper/wrappable.h"
#include "ui/display/display_observer.h"
#include "ui/display/screen.h"
@@ -17,7 +17,6 @@ namespace gfx {
class Point;
class PointF;
class Rect;
class Screen;
} // namespace gfx
namespace gin_helper {
@@ -26,23 +25,25 @@ class ErrorThrower;
namespace electron::api {
class Screen final : public gin_helper::DeprecatedWrappable<Screen>,
class Screen final : public gin::Wrappable<Screen>,
public gin_helper::EventEmitterMixin<Screen>,
private display::DisplayObserver {
public:
static v8::Local<v8::Value> Create(gin_helper::ErrorThrower error_thrower);
static Screen* Create(gin_helper::ErrorThrower error_thrower);
static gin::DeprecatedWrapperInfo kWrapperInfo;
static const gin::WrapperInfo kWrapperInfo;
gin::ObjectTemplateBuilder GetObjectTemplateBuilder(
v8::Isolate* isolate) override;
const char* GetTypeName() override;
const gin::WrapperInfo* wrapper_info() const override;
const char* GetHumanReadableName() const override;
const char* GetClassName() const { return "Screen"; }
// disable copy
Screen(const Screen&) = delete;
Screen& operator=(const Screen&) = delete;
protected:
Screen(v8::Isolate* isolate, display::Screen* screen);
// Make public for cppgc::MakeGarbageCollected.
explicit Screen(display::Screen* screen);
~Screen() override;
gfx::Point GetCursorScreenPoint(v8::Isolate* isolate);