github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-04-10 03:01:51 -04:00
Code Issues Packages Projects Releases Wiki Activity

refactor: prefer using base::NoDestructor to base::{Singleton,LazyInstance} (#41400)

Browse Source 
refactor: prefer using base::NoDestructor to base::{Singleton,LazyInstance}
This commit is contained in:
Shelley Vohr
2024-02-23 10:35:20 +01:00
committed by GitHub
parent 26131b23b8
commit e95673b052
12 changed files with 44 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
shell/browser/badging/badge_manager_factory.cc
View File

@@ -21,7 +21,8 @@ BadgeManager* BadgeManagerFactory::GetForBrowserContext(
// static
BadgeManagerFactory* BadgeManagerFactory::GetInstance() {
return base::Singleton<BadgeManagerFactory>::get();
static base::NoDestructor<BadgeManagerFactory> instance;
return instance.get();
}
BadgeManagerFactory::BadgeManagerFactory()

4
shell/browser/badging/badge_manager_factory.h
View File

@@ -9,7 +9,7 @@
namespace base {
template <typename T>
struct DefaultSingletonTraits;
class NoDestructor;
}
namespace badging {
@@ -30,7 +30,7 @@ class BadgeManagerFactory : public BrowserContextKeyedServiceFactory {
BadgeManagerFactory& operator=(const BadgeManagerFactory&) = delete;
private:
friend struct base::DefaultSingletonTraits<BadgeManagerFactory>;
friend base::NoDestructor<BadgeManagerFactory>;
BadgeManagerFactory();
~BadgeManagerFactory() override;