From eb62abcc2346ac0d5d7f589ec49a831ca377baeb Mon Sep 17 00:00:00 2001 From: Felix Rieseberg Date: Sun, 5 Jun 2016 18:30:49 -0700 Subject: [PATCH] :art: Log a warning if an extension's manifest cannot be parsed Also logs a clean warning if an extension's manifest is incomplete, missing, or can otherwise not be parsed. --- lib/browser/chrome-extension.js | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/lib/browser/chrome-extension.js b/lib/browser/chrome-extension.js index e480d88f9a..05368f9541 100644 --- a/lib/browser/chrome-extension.js +++ b/lib/browser/chrome-extension.js @@ -20,7 +20,15 @@ const generateExtensionIdFromName = function (name) { // Create or get manifest object from |srcDirectory|. const getManifestFromPath = function (srcDirectory) { - const manifest = JSON.parse(fs.readFileSync(path.join(srcDirectory, 'manifest.json'))) + let manifest + + try { + manifest = JSON.parse(fs.readFileSync(path.join(srcDirectory, 'manifest.json'))) + } catch (err) { + console.warn(`Attempted to load extension from ${srcDirectory}, but parsing the manifest failed.`) + console.warn('Error encountered:', err) + } + if (!manifestNameMap[manifest.name]) { const extensionId = generateExtensionIdFromName(manifest.name) console.log(extensionId)