From ed8e57e424d69cfa34c3ec113fd9ef69457410d3 Mon Sep 17 00:00:00 2001 From: Cheng Zhao Date: Wed, 3 Mar 2021 02:34:41 +0900 Subject: [PATCH] test: add more logging for a few tests. (#27956) * test: add logging for app.relaunch test * test: compare more fields in extension test --- spec-main/api-app-spec.ts | 11 +++++++++-- spec-main/extensions-spec.ts | 6 +++--- 2 files changed, 12 insertions(+), 5 deletions(-) diff --git a/spec-main/api-app-spec.ts b/spec-main/api-app-spec.ts index 7901795482..c2f442778a 100644 --- a/spec-main/api-app-spec.ts +++ b/spec-main/api-app-spec.ts @@ -286,13 +286,20 @@ describe('app module', () => { } else if (String(data) === 'true' && state === 'first-launch') { done(); } else { - done(`Unexpected state: ${state}`); + done(`Unexpected state: "${state}", data: "${data}"`); } }); }); const appPath = path.join(fixturesPath, 'api', 'relaunch'); - cp.spawn(process.execPath, [appPath]); + const child = cp.spawn(process.execPath, [appPath]); + child.stdout.on('data', (c) => console.log(c.toString())); + child.stderr.on('data', (c) => console.log(c.toString())); + child.on('exit', (code) => { + if (code !== 0) { + done(`Process exited with code ${code}`); + } + }); }); }); diff --git a/spec-main/extensions-spec.ts b/spec-main/extensions-spec.ts index d7cc01cdd7..fdd2bf8e20 100644 --- a/spec-main/extensions-spec.ts +++ b/spec-main/extensions-spec.ts @@ -152,13 +152,13 @@ describe('chrome extensions', () => { const [, loadedExtension] = await loadedPromise; const [, readyExtension] = await emittedOnce(customSession, 'extension-ready'); - expect(loadedExtension.id).to.equal(extension.id); - expect(readyExtension.id).to.equal(extension.id); + expect(loadedExtension).to.deep.equal(extension); + expect(readyExtension).to.deep.equal(extension); const unloadedPromise = emittedOnce(customSession, 'extension-unloaded'); await customSession.removeExtension(extension.id); const [, unloadedExtension] = await unloadedPromise; - expect(unloadedExtension.id).to.equal(extension.id); + expect(unloadedExtension).to.deep.equal(extension); }); it('lists loaded extensions in getAllExtensions', async () => {