github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-04-10 03:01:51 -04:00
Code Issues Packages Projects Releases Wiki Activity

refactor: plumb RFH instead of RPH for notifications (#28790)

Browse Source
This commit is contained in:
Jeremy Rose
2021-04-29 11:23:28 -07:00
committed by GitHub
parent 37f7e66873
commit ee8b69d067
7 changed files with 32 additions and 32 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
shell/browser/notifications/platform_notification_service.cc
View File

@@ -78,7 +78,7 @@ PlatformNotificationService::PlatformNotificationService(
PlatformNotificationService::~PlatformNotificationService() = default;
void PlatformNotificationService::DisplayNotification(
content::RenderProcessHost* render_process_host,
content::RenderFrameHost* render_frame_host,
const std::string& notification_id,
const GURL& origin,
const GURL& document_url,
@@ -102,7 +102,7 @@ void PlatformNotificationService::DisplayNotification(
auto notification = presenter->CreateNotification(delegate, notification_id);
if (notification) {
browser_client_->WebNotificationAllowed(
render_process_host->GetID(),
render_frame_host,
base::BindRepeating(&OnWebNotificationAllowed, notification,
notification_resources.notification_icon,
notification_data));

2
shell/browser/notifications/platform_notification_service.h
View File

@@ -23,7 +23,7 @@ class PlatformNotificationService
protected:
// content::PlatformNotificationService:
void DisplayNotification(
content::RenderProcessHost* render_process_host,
content::RenderFrameHost* render_frame_host,
const std::string& notification_id,
const GURL& origin,
const GURL& document_url,