github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-04-10 03:01:51 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix: crash in gin::wrappable::secondweakcallback (#45378)

Browse Source 
fix: crash in gin::wrappable::secondweakcallback (#45368)
This commit is contained in:
Keeley Hammond
2025-01-29 15:04:08 -08:00
committed by GitHub
parent e99328a45e
commit ef1ad85082
19 changed files with 230 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
shell/common/api/electron_api_url_loader.cc
View File

@@ -819,4 +819,8 @@ const char* SimpleURLLoaderWrapper::GetTypeName() {
return "SimpleURLLoaderWrapper";
}
void SimpleURLLoaderWrapper::WillBeDestroyed() {
ClearWeak();
}
} // namespace electron::api

3
shell/common/api/electron_api_url_loader.h
View File

@@ -66,6 +66,9 @@ class SimpleURLLoaderWrapper final
v8::Isolate* isolate) override;
const char* GetTypeName() override;
// gin_helper::CleanedUpAtExit
void WillBeDestroyed() override;
private:
SimpleURLLoaderWrapper(ElectronBrowserContext* browser_context,
std::unique_ptr<network::ResourceRequest> request,