github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-01-27 00:09:09 -05:00
Code Issues Packages Projects Releases Wiki Activity

fix: correctly crash when there is no crashReporter (#20388)

Browse Source 
* fix: correctly crash when there is no crashReporter

* test: correctly crash when there is crashReporter
This commit is contained in:
Cheng Zhao
2019-10-02 02:20:21 +09:00
committed by John Kleinschmidt
parent 969b4d1dd3
commit ef690c035d
4 changed files with 29 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
shell/common/crash_reporter/crash_reporter_win.cc
View File

@@ -28,9 +28,17 @@ namespace {
#if defined(_WIN64)
int CrashForException(EXCEPTION_POINTERS* info) {
auto* reporter = crash_reporter::CrashReporterWin::GetInstance();
if (reporter->IsInitialized())
if (reporter->IsInitialized()) {
reporter->GetCrashpadClient().DumpAndCrash(info);
return EXCEPTION_CONTINUE_SEARCH;
return EXCEPTION_CONTINUE_SEARCH;
}
// When there is exception and we do not have crashReporter set up, we just
// let the execution continue and crash, which is the default behavior.
//
// We must not return EXCEPTION_CONTINUE_SEARCH here, as it would end up with
// busy loop when there is no exception handler in the program.
return EXCEPTION_CONTINUE_EXECUTION;
}
#endif