github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-04-10 03:01:51 -04:00
Code Issues Packages Projects Releases Wiki Activity

refactor: clean up Session with CleanedUpAtExit (#24603)

Browse Source
This commit is contained in:
Jeremy Rose
2020-07-20 12:13:33 -07:00
committed by GitHub
parent e5cb22b7f9
commit f0953902db
4 changed files with 17 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
shell/browser/api/electron_api_session.cc
View File

@@ -942,8 +942,6 @@ gin::Handle<Session> Session::CreateFrom(
// The Sessions should never be garbage collected, since the common pattern is
// to use partition strings, instead of using the Session object directly.
handle->Pin(isolate);
ElectronBrowserMainParts::Get()->RegisterDestructionCallback(
base::BindOnce([](Session* session) { delete session; }, handle.get()));
App::Get()->EmitCustomEvent("session-created",
handle.ToV8().As<v8::Object>());