github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-04-10 03:01:51 -04:00
Code Issues Packages Projects Releases Wiki Activity

refactor: migrate deprecated LazyInstance code to NoDestructor (#40927)

Browse Source 
* refactor: do not use deprecated NoDestructor in javascript_environment.cc

* refactor: do not use deprecated NoDestructor in window_list.cc
This commit is contained in:
Charles Kerr
2024-01-10 14:01:49 -06:00
committed by GitHub
parent c2c64d27fd
commit fac964ac0d
3 changed files with 28 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
shell/browser/javascript_environment.cc
View File

@@ -14,6 +14,7 @@
#include "base/bits.h"
#include "base/command_line.h"
#include "base/feature_list.h"
#include "base/no_destructor.h"
#include "base/task/current_thread.h"
#include "base/task/single_thread_task_runner.h"
#include "base/task/thread_pool/initialization_util.h"
@@ -184,9 +185,6 @@ class EnabledStateObserverImpl final
std::unordered_set<v8::TracingController::TraceStateObserver*> observers_;
};
base::LazyInstance<EnabledStateObserverImpl>::Leaky g_trace_state_dispatcher =
LAZY_INSTANCE_INITIALIZER;
class TracingControllerImpl : public node::tracing::TracingController {
public:
TracingControllerImpl() = default;
@@ -265,11 +263,19 @@ class TracingControllerImpl : public node::tracing::TracingController {
TRACE_EVENT_API_UPDATE_TRACE_EVENT_DURATION(category_enabled_flag, name,
traceEventHandle);
}
void AddTraceStateObserver(TraceStateObserver* observer) override {
g_trace_state_dispatcher.Get().AddObserver(observer);
GetObserverDelegate().AddObserver(observer);
}
void RemoveTraceStateObserver(TraceStateObserver* observer) override {
g_trace_state_dispatcher.Get().RemoveObserver(observer);
GetObserverDelegate().RemoveObserver(observer);
}
private:
static EnabledStateObserverImpl& GetObserverDelegate() {
static base::NoDestructor<EnabledStateObserverImpl> instance;
return *instance;
}
};