diff --git a/.circleci/config/base.yml b/.circleci/config/base.yml index 3245252cc7..d36615bfea 100644 --- a/.circleci/config/base.yml +++ b/.circleci/config/base.yml @@ -486,7 +486,9 @@ step-fix-sync: &step-fix-sync run: name: Fix Sync command: | + SEDOPTION="-i" if [ "`uname`" == "Darwin" ]; then + SEDOPTION="-i ''" # Fix Clang Install (wrong binary) rm -rf src/third_party/llvm-build python3 src/tools/clang/scripts/update.py @@ -496,13 +498,13 @@ step-fix-sync: &step-fix-sync # Remove extra output from calling gclient getdep which always calls update_depot_tools sed -i '' "s/Updating depot_tools... //g" esbuild_ensure_file cipd ensure --root src/third_party/devtools-frontend/src/third_party/esbuild -ensure-file esbuild_ensure_file - - # Fix ninja (wrong binary) - echo 'infra/3pp/tools/ninja/${platform}' `gclient getdep --deps-file=src/DEPS -r 'src/third_party/ninja:infra/3pp/tools/ninja/${platform}'` > ninja_ensure_file - sed -i '' "s/Updating depot_tools... //g" ninja_ensure_file - cipd ensure --root src/third_party/ninja -ensure-file ninja_ensure_file fi + # Make sure we are using the right ninja + echo 'infra/3pp/tools/ninja/${platform}' `gclient getdep --deps-file=src/DEPS -r 'src/third_party/ninja:infra/3pp/tools/ninja/${platform}'` > ninja_ensure_file + sed $SEDOPTION "s/Updating depot_tools... //g" ninja_ensure_file + cipd ensure --root src/third_party/ninja -ensure-file ninja_ensure_file + cd src/third_party/angle rm .git/objects/info/alternates git remote set-url origin https://chromium.googlesource.com/angle/angle.git diff --git a/appveyor-woa.yml b/appveyor-woa.yml index 5ba8c4c686..0f545260ce 100644 --- a/appveyor-woa.yml +++ b/appveyor-woa.yml @@ -51,6 +51,8 @@ environment: clone_folder: C:\projects\src\electron +skip_branch_with_pr: true + # the first failed job cancels other jobs and fails entire build matrix: fast_finish: true @@ -130,6 +132,7 @@ for: } - if "%RUN_GCLIENT_SYNC%"=="true" ( gclient sync --with_branch_heads --with_tags ) else ( gclient runhooks ) - cd src + - ps: $env:PATH="$pwd\third_party\ninja;$env:PATH" - set BUILD_CONFIG_PATH=//electron/build/args/%GN_CONFIG%.gn - gn gen out/Default "--args=import(\"%BUILD_CONFIG_PATH%\") import(\"%GN_GOMA_FILE%\") %GN_EXTRA_ARGS% " - gn check out/Default //electron:electron_lib diff --git a/appveyor.yml b/appveyor.yml index 33035278f9..04f7473ab8 100644 --- a/appveyor.yml +++ b/appveyor.yml @@ -49,6 +49,8 @@ environment: clone_folder: C:\projects\src\electron +skip_branch_with_pr: true + # the first failed job cancels other jobs and fails entire build matrix: fast_finish: true @@ -128,6 +130,7 @@ for: } - if "%RUN_GCLIENT_SYNC%"=="true" ( gclient sync --with_branch_heads --with_tags ) else ( gclient runhooks ) - cd src + - ps: $env:PATH="$pwd\third_party\ninja;$env:PATH" - set BUILD_CONFIG_PATH=//electron/build/args/%GN_CONFIG%.gn - gn gen out/Default "--args=import(\"%BUILD_CONFIG_PATH%\") import(\"%GN_GOMA_FILE%\") %GN_EXTRA_ARGS% " - gn check out/Default //electron:electron_lib