From fedf1d889b047a95103b45e2228d8c36da55d110 Mon Sep 17 00:00:00 2001
From: deepak1556 <hop2deep@gmail.com>
Date: Sat, 9 Dec 2017 23:01:51 +0530
Subject: [PATCH] handle NaN conversion from V8

---
 atom/common/native_mate_converters/v8_value_converter.cc | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/atom/common/native_mate_converters/v8_value_converter.cc b/atom/common/native_mate_converters/v8_value_converter.cc
index 72c5958279..b4935b5e3f 100644
--- a/atom/common/native_mate_converters/v8_value_converter.cc
+++ b/atom/common/native_mate_converters/v8_value_converter.cc
@@ -320,8 +320,12 @@ base::Value* V8ValueConverter::FromV8ValueImpl(
   if (val->IsInt32())
     return new base::Value(val->ToInt32()->Value());
 
-  if (val->IsNumber())
-    return new base::Value(val->ToNumber()->Value());
+  if (val->IsNumber()) {
+    double val_as_double = val->ToNumber()->Value();
+    if (!std::isfinite(val_as_double))
+      return nullptr;
+    return new base::Value(val_as_double);
+  }
 
   if (val->IsString()) {
     v8::String::Utf8Value utf8(val->ToString());